Skip to content

feat(database): add tap to query builders #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
innocenzi wants to merge 1 commit into from
Closed

feat(database): add tap to query builders #1448

innocenzi wants to merge 1 commit into from

Conversation

@innocenzi
Copy link
Member

@innocenzi innocenzi commented Aug 2, 2025 •
edited
Loading

This pull request adds a tap method to all query builders. This is a good way to create reusable scopes:

query(Pilot::class)
	->select()
	->tap(new HasAssignmentScope(AircraftType::PC12))
	->get();

Happy to tweak the naming here if you got better ideas. I initially wanted to use with but it's already used for relationships.

@brendt
Copy link
Member

brendt commented Aug 4, 2025

How about just clone?

@innocenzi
Copy link
Member Author

innocenzi commented Aug 4, 2025

clone in PHP is usually a method that returns a clone of the current object, that would break expectations :/

I could think of apply or transform as other names, but honestly with is the one that makes the most sense to me. However, due to Laravel, not using with for relations would kind of break expectations as well

@brendt
Copy link
Member

brendt commented Aug 6, 2025

I like transform a lot more than tap! Let's do that?

@innocenzi
Copy link
Member Author

innocenzi commented Aug 7, 2025

Let's go with transform then! I'll close this PR and add transform to #1458 because I'd rather avoid the conflicts in the rebase 😭

@innocenzi innocenzi closed this Aug 7, 2025
@brendt brendt deleted the feat/query-tap branch September 16, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@innocenzi @brendt